Forklifting my fixes over to develop as well #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had misread a build failure and had assumed that the static directory had been removed. It was actually the public directory as part of the docusaurus migration. As a result, I had updated this build script to instead build directly into the build/ folder instead of static. However, the lingering copy of the code in static was _overwriting_ the latest build. So, I've re-updated this script to copy back into static which is loading the latest copy of the game now. Moreover, I updated the script to DRY up some things and make it clearer what the script is doing.
jeremymccurdy-redspace
approved these changes
Oct 15, 2024
Contributor
jeremymccurdy-redspace
left a comment
jeremymccurdy-redspace
left a comment
There was a problem hiding this comment.
Approved, but I disagree about dropping the develop branch.
It's always good to have a branch that devs can merge into without any worries about it going public. You could do that with release branches or something too, but using a develop branch is what the team uses as part of their normal git flow.
bugfix/187838797 - Social Card fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should get rid of the develop branch here?